Open
Conversation
lfuelling
force-pushed
the
fix-extension-install
branch
from
7e2f08c to
4f4421d
Compare
Contributor
|
Hi! I'm now looking after this repo, I notice this pull is from quite some time ago, so before I merged it I wanted to ask about this line:
Is this something that should be updated before testing and merging? |
Author
|
I don't think so, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #28 I'm trying to get the installation of extensions without a
.pubfile to work (using the public key in themanifest.json).The modification I made will use the
keyproperty of the manifest in case there is no.pubfile available.Unfortunately there is something buggy and while the extension (
.crx) and the accompanying.jsonfile are copied into theExternal Extensionsfolder, the extension doesn't show up inchrome://extensions.